Skip to content

Display resolved file names#107

Merged
edriouk merged 3 commits into
mainfrom
fix-103
Mar 24, 2026
Merged

Display resolved file names#107
edriouk merged 3 commits into
mainfrom
fix-103

Conversation

@edriouk
Copy link
Copy Markdown
Collaborator

@edriouk edriouk commented Mar 24, 2026

Fixes

#103

Changes

  • expand access sequences before resolving filename
  • add tooltip with resolved and original filename

Screenshots

image

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@edriouk edriouk requested a review from Copilot March 24, 2026 10:59
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 24, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 4f3720e.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes CMSIS Solution Outline View to display filenames with access sequences resolved, and adds a tooltip showing both resolved and original file strings (Issue #103).

Changes:

  • Expand access sequences before computing the displayed file label (basename).
  • Add a Markdown tooltip containing both resolved and original file path/name when expansion changes the string.
  • Update the USBD outline reference output to reflect the new label + tooltip behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
test-data/solutions/USBD/CmsisViewTreeRef.txt Updates expected outline tree output to show resolved labels and the new tooltip content.
src/views/solution-outline/tree-structure/solution-outline-file-item.ts Uses resolved paths to compute displayed filename and sets a resolved/original tooltip when access sequences expand.

Comment thread src/views/solution-outline/tree-structure/solution-outline-file-item.ts Outdated
@edriouk edriouk requested a review from brondani March 24, 2026 11:52
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 24, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.01%.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
.../solution-outline/tree-structure/solution-outline-file-item.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Copy Markdown
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edriouk edriouk merged commit 29f4f93 into main Mar 24, 2026
12 checks passed
@edriouk edriouk deleted the fix-103 branch March 24, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants